feat: getResourceType() uses initiatorType when file extension missing #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williazz
force-pushed
the
ResourceTypeFix
branch
from
849f1b7
to
3733039
Compare
williazz
changed the title
williazz
force-pushed
the
ResourceTypeFix
branch
from
3733039
to
7704dc1
Compare
I agree -- love this analysis. I think we should consider this for the next major version. |
qhanam
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from an issue spotted in #450 and #448. See #450 (comment)
The ResourcePlugin mislabels
fileType. Currently,fileTypemaps to buckets of file extensions fromPerformanceResourceTiming.name(e.g. ".jpg" and ".png" map to "image"). However, file extensions cannot be trusted to exist, such as during redirects. When extensions are missing, events are mislabelled as "other".I have considered two solutions:
My recommendation is (1), which this PR implements. This is the least obtrusive method and we can always go to (2) later. If we were implementing this from scratch, I would instead recommend (2) because fileType is NOT a W3C concept found in the PerformanceResourceTiming schema.
To help me review, please also read initiatorType documentation to see if I missed any mappings from
initiatorType->fileType.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.