fix: Use PerformanceObserver to act as a second check to prevent returning 0 for duration and loadEventEnd #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
1.1.0
and later has a bug which causescom.amazon.rum.performance_navigation_event.duration
to be0
when the web client loads beforewindow.load
has been fired.Root Cause:
load
when the page has finished loading according to documentations, but there seems to be cases where it is actually fired before theloadEventEnd
is fired.navigation_events
as soon as window firedload
.navigation_events
emits 0 for fields such asduration
,loadEventEnd
, etc.This PR addresses the issue by doing the following:
loadEventEnd
) and directly record the values.Verifications:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.