New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type name to include only 2 tokens #7

Closed

rjlohan opened this issue Apr 19, 2019 · 2 comments

Labels

Contributor

rjlohan commented Apr 19, 2019

To support certain partners or types where an Organization::Service::Resource namespace is hard to fulfil. Simple example; AWS::::Account

The text was updated successfully, but these errors were encountered:

rjlohan added the enhancement label

Contributor Author

rjlohan commented Jun 12, 2019

I like this explanation provided by @chgeorgeamzn

https://www.youtube.com/watch?v=xOrgLj9lOwk

Contributor

PatMyron commented Sep 1, 2020 •

edited

Loading

While custom resources have unfortunately already broken this assumption, I think it'd be simpler to avoid expanding to allow more uncommon unexpected resource type name patterns, especially since CloudFormation template recognition frequently relies on resource type patterns since AWSTemplateFormatVersion is optional: aws-cloudformation/cfn-lint#1171, aws-cloudformation/cfn-lint-visual-studio-code#99, aws/aws-toolkit-jetbrains#1715 (comment), https://github.com/github/super-linter/pull/231#discussion_r445708695, mwpearce/vscode-cfn-nag#6, joenye/coc-cfn-lint#3 (comment), aws-cloudformation/cfn-lint-atom#29

The public AWS::::Account resource type will likely just be AWS::Organizations::Account

Some other resource types might be a bit more odd, but we should be able to find something suitable for them

PatMyron closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment