Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::ECS::TaskDefinition strict attributes #1514

Closed
deleugpn opened this issue May 6, 2020 · 1 comment
Closed

AWS::ECS::TaskDefinition strict attributes #1514

deleugpn opened this issue May 6, 2020 · 1 comment

Comments

@deleugpn
Copy link

deleugpn commented May 6, 2020

cfn-lint version: 0.30.1

Description of issue.
Attributes Cpu and Memory are too strict for AWS::ECS::TaskDefinition. They are documented as String but they are obviously numbers. As such, it would be nice if we could use numeric values in our templates for better readability.

Template sample:

  ProxyTaskDefinition:
    Type: AWS::ECS::TaskDefinition
    Properties:
      ContainerDefinitions:
        - Essential: true
          Image: !Ref Image
          LogConfiguration:
            LogDriver: awslogs
            Options:
              awslogs-group: !Ref LogGroup
              awslogs-region: !Ref 'AWS::Region'
              awslogs-stream-prefix: task
          Name: nginx
          PortMappings:
            - ContainerPort: 80
          Privileged: false
      Cpu: 512
      Memory: 1024
      Family: nginx-proxy
      NetworkMode: awsvpc
      ExecutionRoleArn: !ImportValue ECSTaskExecutionRoleArn
      TaskRoleArn: !ImportValue ECSTaskExecutionRoleArn
      RequiresCompatibilities: [FARGATE]
@PatMyron
Copy link
Contributor

PatMyron commented May 6, 2020

duplicate of #547

@PatMyron PatMyron closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants