Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setPreferredMFA method throws error when setting totp with no cellphone #859

Merged
merged 5 commits into from
May 18, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
fixes #806 #618 #846
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@powerful23 powerful23 requested a review from richardzcode as a code owner May 18, 2018 03:54
@codecov-io
Copy link

Codecov Report

Merging #859 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #859   +/-   ##
======================================
  Coverage    87.3%   87.3%           
======================================
  Files          77      77           
  Lines        3670    3670           
  Branches      696     696           
======================================
  Hits         3204    3204           
  Misses        443     443           
  Partials       23      23
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 88.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b86c0...834acc8. Read the comment docs.

Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling TOTP using Amplify FAILS when the user does not have a cellphone number in the profile
3 participants