Analytics client context configurable #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context-configurable
mbahar
approved these changes
May 17, 2018
mlabieniec
suggested changes
May 18, 2018
| app_version_code: clientContext.appVersionCode, | ||
| app_package_name: clientContext.appPackageName, | ||
| }, | ||
| env: { |
There was a problem hiding this comment.
Can we default some of these to what's detected in Platform? For example platform could be navigator.product or browser...etc (if available), perhaps use the common/Platform class?
There was a problem hiding this comment.
Using clientInfo to get the default info.
| }, | ||
| services: { | ||
| mobile_analytics: { | ||
| app_id: appId | ||
| app_id: appId, | ||
| sdk_name: 'aws-amplify' |
There was a problem hiding this comment.
can we put this in common/platform ? Just incase we want to use it elsewhere
…b.com/powerful23/aws-amplify into analytics-client-context-configurable
This was referenced Mar 14, 2021
Merged
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
To allow user pass configurations into client context
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.