Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react attr generation for collectionBindingProperties #53

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Sep 9, 2021

  • add react attr generation for collectionBindingProperties

Previously:

{(item, index) => (
  <Flex {...props} {...getOverrideProps(props.overrides, "Flex")}>
    <Button
      label
      labelWidth={width}
      backgroundColor={buttonColor.favoriteColor}
      disabled={isDisabled}
      {...props}
      {...getOverrideProps(props.overrides, "Button")}
    ></Button>
  </Flex>
)}

After change:

{(item, index) => (
  <Flex {...props} {...getOverrideProps(props.overrides, "Flex")}>
    <Button
      label={item.username || "hspain@gmail.com"}
      labelWidth={width}
      backgroundColor={buttonColor.favoriteColor}
      disabled={isDisabled}
      {...props}
      {...getOverrideProps(props.overrides, "Button")}
    ></Button>
  </Flex>
)}

@dpilch dpilch requested a review from frimfram September 9, 2021 15:10
@dpilch dpilch merged commit 33390ed into main Sep 10, 2021
@dpilch dpilch deleted the collection-binding branch September 10, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants