Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Architecture Property on defineFunction #2370

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

caioquirino
Copy link
Contributor

Problem

Allows the users to choose between the available Lambda runtime architectures (x86_64 and arm64).

Issue number, if available: 1820

Changes

Corresponding docs PR, if applicable:

This is a relatively simple change, which only adds the architecture field to the defineFunction function, with x86_64 as its default value to keep backwards compatibility, and converts it to the corresponding CDK API Architecture value.

This change also introduced a new Architecture validation to guarantee that only valid values are used. Tests and documentation changes are also included.

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@caioquirino caioquirino requested review from a team as code owners December 26, 2024 05:13
Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: 2154f03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-function Minor
@aws-amplify/backend Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/tall-parrots-sort.md Outdated Show resolved Hide resolved
packages/backend-function/src/factory.test.ts Outdated Show resolved Hide resolved
caioquirino and others added 2 commits December 31, 2024 01:13
Co-authored-by: Kamil Sobol <sobol.k.r@gmail.com>
Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com>
@sobolk sobolk merged commit b1c0f0d into aws-amplify:main Dec 31, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants