Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean null values out of arrays #63

Merged
merged 2 commits into from
May 7, 2020

Conversation

clareliguori
Copy link
Member

Fixes #53

The following task definition input for the action:

      "logConfiguration": {
        "logDriver": "awsfirelens",
        "options": {
          "KeyName": ""
        },
        "secretOptions": [
          {
            "name": "",
            "valueFrom": ""
          }
        ]
      },

currently generates the following input to RegisterTaskDefinition:

      "logConfiguration": {
        "logDriver": "awsfirelens",
        "secretOptions": [
          null
        ]
      },

Because of the null value, the only error message is Cannot read property 'name' of null. This PR removes all the null values so that a proper error message is given to the user.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@clareliguori clareliguori requested a review from a team May 6, 2020 23:27
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯

Copy link

@hossain-rayhan hossain-rayhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@mergify mergify bot merged commit 6b1f3e4 into aws-actions:master May 7, 2020
s3cube pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy via Actions: Cannot read property 'name' of null
3 participants