feat: Tags for services and ad-hoc run #629
Conversation
|
I encountered an issue when wanted to propagate tags from task definition for run-task because of #249 (comment). The describe-task-definition can return tags, but it need to be merged to the task definition, which is not easy to do with cli or in amazon-ecs-render-task-definition (see aws-actions/amazon-ecs-render-task-definition#317). |
guikcd
force-pushed
the
tags
branch
2 times, most recently
from
09efb45 to
ee0f18e
Compare
|
@kg-aws ready to review |
| @@ -1446,4 +1467,36 @@ describe('Deploy to ECS', () => { | |||
| expect(core.setFailed).toHaveBeenNthCalledWith(1, 'Failed to register task definition in ECS: Could not parse'); | |||
| expect(core.setFailed).toHaveBeenNthCalledWith(2, 'Could not parse'); | |||
| }); | |||
|
|
|||
| test('propagate service tags from service and enable ecs managed tags', async () => { | |||
There was a problem hiding this comment.
Hi @guikcd, thanks for this PR!
I believe we are missing unit tests that checks the run-task-tags functionality. Would it also be possible to add unit tests for the run-task-tags parameter/functionality as part of existing or as a new test.
There was a problem hiding this comment.
I've modified the existing test run task with options to verify run-task-tags.
Issue #, if available:
Closes: #605, closes: #538
Description of changes:
Add support for tags:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.