Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Remove dependency on docker client #598

Open
runlevel5 opened this issue Feb 21, 2024 · 6 comments
Open

[Feature request] Remove dependency on docker client #598

runlevel5 opened this issue Feb 21, 2024 · 6 comments
Labels
feature-request A feature should be added or improved.

Comments

@runlevel5
Copy link

runlevel5 commented Feb 21, 2024

From my understanding in order to perform authentication, the action utilises the docker client to perform docker login. Which is fine. However this dependency will make this plugin incompatible with environment that does not ship docker client (or users could not install any software). IMHO the action should take advantage of the HTTP API endpoint to perform this task instead.

One example I run into is that I run gitub action runners on AWS Lambda & ECS & ECS Fargate environment which lacks the docker CLI. The error output I got is:

Error: Unable to locate executable file: docker. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.
@runlevel5 runlevel5 added the feature-request A feature should be added or improved. label Feb 21, 2024
@szhekpisov
Copy link

Same here, have a version v2.

@runlevel5
Copy link
Author

I am more than happy to offer a Pull Request if the team approves this proposal

@gricey432
Copy link

I think this would also solve #434 ?

@runlevel5
Copy link
Author

I think this would also solve #434 ?

Yes it would

@mohitgarg
Copy link

@runlevel5 is there a workaround for this? I tried using another runner but then node would fail in $PATH.

@runlevel5
Copy link
Author

@runlevel5 is there a workaround for this? I tried using another runner but then node would fail in $PATH.

AFAIK the answer is no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants