Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure not loading naughty.dbus #1285

Closed
blueyed opened this issue Dec 21, 2016 · 8 comments
Closed

Allow to configure not loading naughty.dbus #1285

blueyed opened this issue Dec 21, 2016 · 8 comments

Comments

@blueyed
Copy link
Member

blueyed commented Dec 21, 2016

I am using the following hack to not load naughty.dbus in my config, but it might still be loaded when something requires naughty later.

local _dbus = dbus; dbus = nil
local naughty = require("naughty")
dbus = _dbus

(to skip loading in

if dbus then
naughty.dbus = require("naughty.dbus")
end
)

Apart from avoiding this hack, it would be good to configure this more explicitly, in case you want to use dunst etc for notifications (over DBUS) instead.

Does this belong/fit into naughty.config?

@psychon
Copy link
Member

psychon commented Dec 21, 2016

How about package.loaded["naughty.dbus"] = {}?
Dunno about adding something like this to naughty.config.

@topisani
Copy link

none of the above hacks seem to work for me. I also thing this would be a great addition as a config option, so i can use naughty for custom awesome trickery and xfce4-notifyd for notifications, since it has the brightness/volume bars etc.

@blueyed
Copy link
Member Author

blueyed commented Jan 14, 2017

@topisani
The 1st one should work: you need to wrap the already existing require("naughty").

@topisani
Copy link

yeah thats what i tried, it didnt seem like it worked... anyway, i just commented out those three lines from the file mentioned by OP and did a manual build - that worked.

@Elv13
Copy link
Member

Elv13 commented Jun 9, 2019

The code affecting this issue has been replaced. It is still not possible to really configure using naughty or not, but assuming you want to disable naughty because it wasn't a very good notification engine, you might want to revisit it now that much effort has been spent into making it good. If support for external notification system is really required, report a bug with a good argument. Note that external bars are already unsupported, so this doesn't set a precedent.

@Elv13 Elv13 closed this as completed Jun 9, 2019
@juanibiapina
Copy link

Does anyone have updates on this? What's the current workaround?

@juanibiapina
Copy link

juanibiapina commented Apr 3, 2021

Looks like package.loaded["naughty.dbus"] = {} is the hack in 4.3.

@actionless
Copy link
Member

actionless commented Apr 5, 2021

i think is good idea to have naughty.disable() instead of forcing users to do monkey-patching

(i myself using naughty though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants