You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This project is a fork of whatsapp-api. As the project was abandoned by the original author, all future improvements will be in this repo.
I'm interested in your fork but it's difficult to tell what its differences and purposes are.
I don't see any public message in the original repo stating that it's abandoned, and the most recent PR merged was only a few months ago: chrishubert/whatsapp-api#246
Also it seems like it was merged by you (@avoylenko), so if you have commit rights on that project I wonder why you would not continue development there.
But more importantly, I see commits in this repo made directly to main without PRs, and no changelog or description of what's being changed. Some changes appear to be breaking but I'm not sure whether semver is being used or not either.
If you're intending the fork to be used by others then having PRs with descriptions, changelogs, and consistent versioning would go a long way!
If the project is not really intended for public consumption that's useful info as well.
Thank you!
The text was updated successfully, but these errors were encountered:
Thank you for your detailed message. Appreciate this.
I dropped from contributing to the chrishubert/whatsapp-api project since I don't right to accept my own PRs. You can find a few my PRs that left not merged to the main branch. Moreover, I'm using the project at my work, so fixing critical bugs and adding new functionality is crucial in my case. I just heard from Christophe that he doesn't have a free time to contribute to the project, this might change in the future, so I can't add the public message about sunsetting of the project.
A few words about this repo, I was in rush adding new functionality and refactoring the project, so skipped the PR stage. This definitely will be changed for all upcoming changes and we won't have breaking changes without mentioning this in the release description.
Hello! The readme says:
I'm interested in your fork but it's difficult to tell what its differences and purposes are.
I don't see any public message in the original repo stating that it's abandoned, and the most recent PR merged was only a few months ago: chrishubert/whatsapp-api#246
Also it seems like it was merged by you (@avoylenko), so if you have commit rights on that project I wonder why you would not continue development there.
But more importantly, I see commits in this repo made directly to
main
without PRs, and no changelog or description of what's being changed. Some changes appear to be breaking but I'm not sure whether semver is being used or not either.If you're intending the fork to be used by others then having PRs with descriptions, changelogs, and consistent versioning would go a long way!
If the project is not really intended for public consumption that's useful info as well.
Thank you!
The text was updated successfully, but these errors were encountered: