Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom media types aren't handled properly when originating in setUri() #54

Closed
avoidwork opened this issue Dec 5, 2016 · 0 comments
Closed
Assignees

Comments

@avoidwork
Copy link
Owner

avoidwork commented Dec 5, 2016

The setUri() method calls sync() which has no ability to do a custom transformation of the data it receives from request() creating a potential gap in functionality for developers dealing with unofficial media types.

A custom tranform that fires when the arg is a text should be good enough to intercept & handle the text string.

Most likely it's reasonable to create an onrequest() function which accepts the input at https://github.com/avoidwork/haro/blob/master/src/haro.js#L501 if the typeof is "string".

@avoidwork avoidwork self-assigned this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant