Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors for titles with spaces don't work on awesome-go.com website (they work okay in README.md on github). #983

Closed
Epse opened this issue Jun 9, 2016 · 6 comments
Labels

Comments

@Epse
Copy link

Epse commented Jun 9, 2016

In the web page version on http://awesome-go.com clicking the link labeled "actual middlewares" doesn't do anything. The ID doesn't seem to exist

@dmitshur
Copy link
Collaborator

Hi @Epse,

Thanks for reporting this. It's a bug.

However, it affects more than just that one section, it's anything that has a space.

It happens because there is currently a mismatch in how the header anchors are generated on the website and on the README when viewed on github. Notice that "Actual middlewares" link works in GitHub:

https://github.com/avelino/awesome-go/blob/master/README.md#actual-middlewares

We should fix this inconsistency and make the website work as well.

This issue will track that (I'm a little surprised we didn't already have one open; this is a known issue that was raised before IIRC).

@dmitshur dmitshur added the bug label Jun 10, 2016
@dmitshur dmitshur changed the title #actual-middlewares doesn't exist Anchors for titles with spaces don't work on awesome-go.com website (they work okay in README.md on github). Jun 10, 2016
@kirillDanshin
Copy link
Contributor

yep, it has id="actualmiddlewares" instead of id="actual-middlewares".
It's a bug in showdown.js that is obsolete (see // Copyright (c) 2007 John Fraser. in http://awesome-go.com/assets/showdown.js).
I think we need to use something more actual. We can upgrade to markdown-js for example. Any objections?
@shurcooL @avelino @matrixik FYI.

@dmitshur
Copy link
Collaborator

dmitshur commented Jun 10, 2016

I don't know anything about JavaScript markdown libraries, so I can't offer comments. But no objections from me, as long as it works and nothing is broken. :)

@kirillDanshin
Copy link
Contributor

fixed in 9959a7b
also I've update the design.
check it out @shurcooL @avelino @Epse

@avelino
Copy link
Owner

avelino commented Jun 10, 2016

thanks @kirillDanshin
What do you think of generating the HTML around build and automatically update the index.html in the branch "gh-pages"? So we will be indexed in Google and we can work on SEO.

@kirillDanshin
Copy link
Contributor

@avelino
I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants