Remove the original converter of LLVM IR into BIR from llvmir2hll #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to still call the converter |
|
Good point. I see two options:
I would go with number 2 as I do not believe we will have another converter in the future. Also, having multiple converters would be unnecessarily hard to maintain (we would have to write regression tests for both of them). What is your take on this? |
|
Based on a discussion, we have decided to go with option number 2. I will adjust the PR to reflect that. |
Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we can remove the original (old) one. Reasons: * Nobody will probably ever use it. * We will not have to maintain two converters. * Fewer `.cpp` files to compile. Notes: * We have to preserve labels_handler.cpp from the original converter as this module is also used by the new converter. * The retdec-decompiler.py script had to be also updated (to prevent users from specifying 'orig' via --backend-llvmir2bir-converter.
…onverters. We do not believe that we will have another converter in the future. Also, having multiple converters would be unnecessarily hard to maintain (we would have to write regression tests for both of them).
s3rvac
force-pushed
the
removal-of-original-converter-in-llvmir2hll
branch
from
b12e832
to
9759427
Compare
|
Done in commit 9759427. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we can remove the original (old) one.
Reasons:
.cppfiles to compile.Notes:
labels_handler.cppfrom the original converter as this module is also used by the new converter.retdec-decompiler.pyscript had to be also updated (to prevent users from specifying'orig'via--backend-llvmir2bir-converter.Closes #508.