-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fileinfo produces different order of detected tools on macOS #262
Comments
I have analyzed this. During the ordering of the detected tools by 131 // Prefer heuristic
132 return b.source == DetectionMethod::SIGNATURE; Here are the values of
What seems fishy to me is that the comparison result of two tools (which is, in fact, the result of |
This function is quite problematic indeed, as it considers a lot of attributes with different priorities which leads to huge branching. I believe in this case we consider both detections equal so both I can think of two potential fixes:
|
Yes, using |
Fixed in ce25b14ce. |
fileinfo
produces different order of detected tools on macOS than on Linux/Windows.Input
Run
where
UPX121_C_small.7
comes from our regression-test suite.Output
Linux:
macOS:
As you can see, the two lines are swapped.
Expected output
Linux:
macOS:
That is, the output should be the same on all systems.
Notes
This difference in the order of the detected tools is the reason why the following regression test fails on macOS:
Configuration
master
)The text was updated successfully, but these errors were encountered: