-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaObject#show setting up instance variables unnecessarily slowing down page #5477
Comments
I did a quick investigation on this and found that it will be a bit harder than I had anticipated. It also revealed some functionality gaps that we will probably need to address before release. Functionality that needs to be added to ramp:
The player page needs to setup media object and master file objects on page load in order to populate the share panel. It seems like there are two options for handling this: put all of the needed information into the IIIF manifest or have the page dynamically request Possible changes to avoid needing
Other places where media object/master file information is needed:
|
Looking again at Solr calls for the item show page might be the only quick win at the moment. |
Wrote up new issue for the rest of the work mentioned in my comment above: #5543 |
Description
The MediaObject#show action setup a number of instance variables for the player which may not be necessary now that ramp is rendering pretty much all of the item show page. The work to setup these variables are also duplicative given ramp requests the IIIF manifest. I'm guessing that section information is being fetched from solr and stream tokens setup which aren't used at all.
@media_object
is probably still needed for certain authorization checks but we can make sure that SpeedyAF isn't loading any children relations that aren't needed. (See note in #5476)Done Looks Like
The text was updated successfully, but these errors were encountered: