Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default timeout / ensure worker exits after unhandled rejections #2310

Closed
Oloompa opened this issue Dec 13, 2019 · 1 comment · Fixed by #2329
Closed

Set default timeout / ensure worker exits after unhandled rejections #2310

Oloompa opened this issue Dec 13, 2019 · 1 comment · Fixed by #2329
Assignees
@novemberborn
Labels
breaking requires a SemVer major release enhancement new functionality help wanted
Milestone
v3

Comments

@Oloompa
Copy link

Oloompa commented Dec 13, 2019 •
edited
Loading

I have tests which are executed in CI. Sometime it just hangs a lot of time cause test never end due to an uncaught promise error.

If i run the server in production it should crash (but currently it do not).

We test in CI to prevent unexpected bug. Ava currently wait and consume CI time for unhandled async rejections.

It would save cost if ava could fail test instantly.
@novemberborn
Copy link
Member

Yea, we really ought to set a default timeout, even if it's say 30 seconds. Will try and get that into the next major release.

@novemberborn novemberborn added breaking requires a SemVer major release enhancement new functionality help wanted labels Dec 21, 2019
@novemberborn novemberborn added this to the v3 milestone Dec 21, 2019
@novemberborn novemberborn changed the title Ava should stop just like nodejs crash on unhandle rejections Set default timeout / ensure worker exists after unhandled rejections Jan 2, 2020
@novemberborn novemberborn changed the title Set default timeout / ensure worker exists after unhandled rejections Set default timeout / ensure worker exits after unhandled rejections Jan 2, 2020
@novemberborn novemberborn mentioned this issue Jan 2, 2020
Merged
@novemberborn novemberborn self-assigned this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novemberborn novemberborn

Labels
breaking requires a SemVer major release enhancement new functionality help wanted
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

Set a default timeout of 10 seconds avajs/ava
2 participants
@novemberborn @Oloompa