Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompile Contract Improvements #333

Closed
ceyonur opened this issue Nov 2, 2022 · 1 comment · Fixed by #389, #418, #420 or #434
Closed

Precompile Contract Improvements #333

ceyonur opened this issue Nov 2, 2022 · 1 comment · Fixed by #389, #418, #420 or #434
Assignees
@ceyonur
Labels
precompile
Milestone
Subnet-EVM@v0.4.10

Comments

@ceyonur
Copy link
Collaborator

ceyonur commented Nov 2, 2022

Currently stateful precompile package suffers several issues

  • Circular Import Hell with params package
  • instead of using getByKey we can try to use addresses to fetch precompile configurations
  • each precompile contract should have their own package with specific unit tests. Currently all precompile unit tests are in the same file
  • we should reduce places where we need to put precompile key (indicated by `"ADD YOUR PRECOMPILE HERE") in the codebase.
@ceyonur ceyonur self-assigned this Nov 2, 2022
@aaronbuchwald aaronbuchwald added this to the Subnet-EVM@v0.4.5 milestone Nov 29, 2022
@ceyonur ceyonur linked a pull request Dec 2, 2022 that will close this issue
move inline string ABIs to separate files and embed them #383
Merged
@ceyonur ceyonur removed a link to a pull request Dec 2, 2022
move inline string ABIs to separate files and embed them #383
Merged
@ceyonur ceyonur mentioned this issue Dec 2, 2022
Merged
@ceyonur ceyonur linked a pull request Dec 20, 2022 that will close this issue
rework on panics in precompiles #418
Merged
@0xJohnnyGault
Copy link

Caddy has a nice plugin architecture they use that would be a great model for precompiles to follow, if you need some inspiration.

https://caddyserver.com/docs/extending-caddy

This was linked to pull requests Dec 26, 2022
Precompile Specific Packages #420
Merged
introduce precompiles as registrable modules #423
Closed
rename feeconfigmanagerconfig struct #422
Closed
@ceyonur ceyonur linked a pull request Jan 12, 2023 that will close this issue
Generalized upgrades rb #434
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceyonur ceyonur

Labels
precompile
Projects
None yet
Milestone
Subnet-EVM@v0.4.10
3 participants
@ceyonur @aaronbuchwald @0xJohnnyGault