From 487d0d9f4592aefdaebb78529c50e87ef8d59fab Mon Sep 17 00:00:00 2001
From: dhrubabasu <7675102+dhrubabasu@users.noreply.github.com>
Date: Wed, 3 May 2023 14:35:07 -0400
Subject: [PATCH] ban `require.NotEqualValues`

---
 .golangci.yml                  | 1 +
 network/peer/ip_signer_test.go | 2 +-
 utils/sampler/uniform_test.go  | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 85dcbf776388..07aedc063d41 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -68,6 +68,7 @@ linters-settings:
       - 'require\.Error$(# ErrorIs should be used instead)?'
       - 'require\.ErrorContains$(# ErrorIs should be used instead)?'
       - 'require\.EqualValues$(# Equal should be used instead)?'
+      - 'require\.NotEqualValues$(# NotEqual should be used instead)?'
     exclude_godoc_examples: false
   # https://golangci-lint.run/usage/linters#gosec
   gosec:
diff --git a/network/peer/ip_signer_test.go b/network/peer/ip_signer_test.go
index 6d7203a409b5..382501a825bc 100644
--- a/network/peer/ip_signer_test.go
+++ b/network/peer/ip_signer_test.go
@@ -51,5 +51,5 @@ func TestIPSigner(t *testing.T) {
 	require.NoError(err)
 	require.Equal(dynIP.IPPort(), signedIP3.IPPort)
 	require.Equal(uint64(11), signedIP3.Timestamp)
-	require.NotEqualValues(signedIP2.Signature, signedIP3.Signature)
+	require.NotEqual(signedIP2.Signature, signedIP3.Signature)
 }
diff --git a/utils/sampler/uniform_test.go b/utils/sampler/uniform_test.go
index fe66bdb9d27d..34502e313b99 100644
--- a/utils/sampler/uniform_test.go
+++ b/utils/sampler/uniform_test.go
@@ -175,7 +175,7 @@ func TestSeeding(t *testing.T) {
 	s1.Seed(0)
 	v, err := s2.Next()
 	require.NoError(err)
-	require.NotEqualValues(s1Val, v)
+	require.NotEqual(s1Val, v)
 
 	s1.ClearSeed()