Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the alternative login, verify email, and error boundary components to use css variables for colors #3022

Merged
merged 6 commits into from
Sep 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This updates the Alternative Login, Email Verification, and Error Boundary components.

Test

The easiest way to test these is to force the modals to appear by temporarily editing the app.tsx file to always show them.
To display the error boundary you need to introduce an error in code.

  • Smoke test in light and dark mode
  • Compare between production and this branch
  • Enable the Alternative Login Prompt
  • Ensure it still looks the same
  • Enable the Email Verification Modal
  • Ensure it still looks the same
  • Trigger the Error Boundary
  • Ensure it still looks the same

Release

  • Updated the Alternative Login, Email Verification, and Error Boundary components to use CSS variables for colors

@sandymcfadden sandymcfadden added this to the 2.21.0 milestone Sep 27, 2021
@sandymcfadden sandymcfadden self-assigned this Sep 27, 2021
@sandymcfadden sandymcfadden merged commit 2efc452 into develop Sep 28, 2021
@sandymcfadden sandymcfadden deleted the update/alternative-login-verify-account-css branch September 28, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants