Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the note info compontent to use css variables for colors #3021

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Update the note info compontent to use css variables for colors #3021

merged 1 commit into from
Sep 29, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This updates the Note Info components.

Test

  • Smoke test in light and dark mode
  • Have a note with references pointing to it
  • Open the Note Info panel using the (i) icon in the upper right
  • Compare between production and this branch
  • Ensure the note info panel looks the same

Release

  • Updated the Note Info components to use CSS variables for colors

@sandymcfadden sandymcfadden added this to the 2.21.0 milestone Sep 26, 2021
@sandymcfadden sandymcfadden self-assigned this Sep 26, 2021
belcherj
belcherj approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@sandymcfadden sandymcfadden merged commit c36cd5b into develop Sep 29, 2021
@sandymcfadden sandymcfadden deleted the update/note-info-css branch September 29, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

@codebykat codebykat Awaiting requested review from codebykat

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sandymcfadden @belcherj