Fix: Add selected tag to new notes by default

[codebykat]

Fix

Fixes #2423

If you are on a selected tag and choose to add a new note, the new note will now automatically get that tag added to it.

Test

1. Click a tag in the sidebar to select it
2. Create a new note
3. Verify that the new note has the selected tag
4. Create a new note with no tag selected
5. Verify that no tags are added to that note

Release

Fix: Apply selected tag to a new note by default

[dmsnell]

Pretty straight-forward code. You know me: I don't like let or mutation so I left a comment about removing it but the logic looks good. 👍

[codebykat]

@dmsnell I appreciate the review but there's a major bug with this as noted in the TODO, which is why it was still set to draft. Do you know what I need to pass to get it to work with a tag with special characters in its name?

[dmsnell]

since we're writing the tags into the tags array on the note object we shouldn't have to worry about transformation; we should be able to keep it written as typed in the search bar.

withTag should be preserving whatever it's given. when you say "empty" tag can you share the data you are referring to? what makes it empty vs. not having the tag at all?

[codebykat]

I haven't debugged it deeply yet, but the note shows up with an empty tag pill.

[sandymcfadden]

This seems to be all working now. I've updated to get the tagName of the openedTag before sending to withTag as it was expecting a tagName and not a tagHash.

[dmsnell]

we need to rebase this against the latest develop HEAD. state.ui.openedTag is gone and has been replaced by state.ui.collection in #2706, but which thankfully introduced a new openedTag selector as well so we should be able to easily adapt this branch.

[sandymcfadden]

@dmsnell ah yes you're right. I was going to rebase before I merged. I forgot that change would impact this. I'll work on that now.

[sandymcfadden]

Thanks again @dmsnell for that catch. All updated again now.

[dmsnell]

there's nothing I see worth pointing out; it's a clean solution

for testing, did you verify that the added tag is the name of the tag as pulled from the tag bucket, not the tag hash, not a trivial transformation from the tag hash to an unhashed version of the tag? (for example, does it properly at Tag if Tag is opened, because tag is the tag hash there).

[codebykat]

[Can't request changes because I'm the author apparently 😂 ]

There's an oddity that seems to be resetting the notes list to "all notes" after a new note is added. It's still displaying the tag in the title bar, but the note listing is now showing everything, not just notes with that tag:

[sandymcfadden]

for testing, did you verify that the added tag is the name of the tag as pulled from the tag bucket, not the tag hash, not a trivial transformation from the tag hash to an unhashed version of the tag? (for example, does it properly at Tag if Tag is opened, because tag is the tag hash there).

Thanks @dmsnell! The openedTag selector provides us with the tagName, withTag wants the tagName as well and then tests to see if the hash of it matches the hashes of any other tags in the list already before adding it in.
I did test with the example you gave and Tag is added to the note.

[sandymcfadden]

There's an oddity that seems to be resetting the notes list to "all notes" after a new note is added. It's still displaying the tag in the title bar, but the note listing is now showing everything, not just notes with that tag:

Thanks @codebykat! I didn't notice that at all. I've got it updated now so that it displays the note list with the selected tag properly.

[codebykat]

This is my PR so I can't approve it, but this is an approval! It's testing great for me now.