This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
V4.0 #702
Merged
V4.0 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `PHP Warning: DOMDocument::loadHTML(): Empty string supplied as input`, by verifying the content and making sure if it is empty, do not `transformString`.
- closes #619 - depends on facebookarchive/facebook-instant-articles-sdk-php/pull/198
This ingestion flow takes in consideration how is the current status of the setup. If setup is already complete on API, it means a migration, set the configuration as API and the flow goes that way otherwise set the configuration as Open Graph and flow goes this way
- [x] Edit doesn't erase content - [x] Fixed issue on Advanced Settings - [x] Removed extra code
* Removed the wizard * Added a page_id field on the settings * Removed unused pages, javascripts and templates
Open Graph Ingestion Flow
… that is enabled, injects the link rel tag to the amp markup
…up=1 to post uri)
…ad of hard coded strings
…settings() method to decouple from the other classes
…ded links to the official docs
allow markups in footer/copyright
…the php versions yet
…ts with phpcbf. Additional stuff as per reviews.
Adding support to IA->AMP conversion
Fix "Empty string supplied as input" bug
hhvm is breaking a test, see issue #701
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a release PR for v4.0. It includes: