This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Allow for alternative file path for json rules #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to set own file path for the rules-configuration.json file so that developers can specify their own json rules and not run the risk of updates to this plugin effecting the way their transformed instant articles behave.
everton-rosario
suggested changes
Mar 6, 2017
class-instant-articles-post.php
Outdated
| @@ -602,6 +602,7 @@ public function to_instant_article() { | |||
|
|
|||
| // Initialize transformer | |||
| $file_path = plugin_dir_path( __FILE__ ) . 'rules-configuration.json'; | |||
| $file_path = apply_filters('instant_articles_transformer_rules_configuration_json_file_path', $file_path ); | |||
There was a problem hiding this comment.
Just mind the spacing.
$file_path = apply_filters( 'instant_articles_transformer_rules_configuration_json_file_path', $file_path );
💅
There was a problem hiding this comment.
great stuff. many thanks for implementing this little code change/pull request. I'm glad you like it.
|
@andykillen, Thanks for this awesome feature in a really simple way to implement it. |
|
Please join our group @ Facebook: https://web.facebook.com/groups/629655867187397/ |
Added formatting (space before the filter name)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to set own file path for the rules-configuration.json file so that developers can specify their own json rules and not run the risk of updates to this plugin effecting the way their transformed instant articles behave.
This PR: