This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
add vimeo.com into oEmbed $provider_name #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will just a basic iframe (any standard iframe/non oEmbed tag in the content) wrap be added? And Tumblr should be added as well. |
|
@kkranzo as of the latest version you can already use |
diegoquinteiro
suggested changes
Jan 24, 2017
| @@ -41,8 +41,12 @@ function instant_articles_embed_oembed_html( $html, $url, $attr, $post_ID ) { | |||
| $provider_name = 'twitter'; | |||
| } elseif( false !== strpos( $providerURL, 'youtube.com' ) ) { | |||
| $provider_name = 'youtube'; | |||
| } elseif( false !== strpos( $providerURL, 'vimeo.com' ) ) { | |||
There was a problem hiding this comment.
Please fix indentation to use tabs.
fix indent to tabs
|
Indentation looks good, but still need to resolve the conflicts |
diegoquinteiro
approved these changes
Jan 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vimeo.com oEmbed figure wrapping.