This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
New flow #400
Merged
New flow #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @philipjohn, thanks a lot for looking at this in a short timeline! Here's the WIP PR you can comment on. I'll be finishing the last feature today and address any feedback you provide before the EOW. |
diegoquinteiro
force-pushed
the
new_flow
branch
from
dd89066 to
0759dcf
Compare
| public static function add_settings_link_to_plugin_actions( $links ) { | ||
| $link_text = __( 'Settings' ); | ||
| $settings_href = self::get_url(); | ||
| $settings_link = '<a href="' . esc_url( $settings_href ) . '">' . $link_text . '</a>'; |
There was a problem hiding this comment.
$link_text should be wrapped in esc_html() here
|
Thanks @diegoquinteiro - I've left a bunch of inline comments. Mostly escaping choices that should be a quick fix. Otherwise looks good! |
|
@philipjohn I've went ahead and merged after addressing the comments. Please let me know if you have new comments so we can address them in a new PR. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing settings screen with a new layout and flow.
See screenshots:
