check if generic type assembly has been added to set #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1438 +/- ##
===========================================
+ Coverage 79.03% 79.05% +0.01%
===========================================
Files 200 200
Lines 5682 5685 +3
Branches 1143 1144 +1
===========================================
+ Hits 4491 4494 +3
Misses 696 696
Partials 495 495 ☔ View full report in Codecov by Sentry. |
alistairjevans
requested changes
Dec 6, 2024
| @@ -68,6 +68,11 @@ private static void PopulateAllReferencedAssemblies(Type inputType, HashSet<Asse | |||
|
|
|||
| foreach (var genericArgumentType in genericArguments) | |||
| { | |||
| if (holdingSet.Any(a => a.DefinedTypes.Contains(genericArgumentType))) | |||
There was a problem hiding this comment.
For performance reasons, if this only overflows in a tight loop where we're self-referencing, can we please pass into PopulateAllReferencedAssemblies a "HashSet activeWorkingSet" and insert there each time we add a type, then check that active working set instead? This should result in a simple O(1) check for the type having already been seen in this tree.
There was a problem hiding this comment.
Sure thing. Changes have been committed.
tillig
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the holding set to see if the type assembly has already been added to avoid the stack overflow.
#1437