Ignore required properties in the default autowiring property selector. #1369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during the docs creation for required properties, before this change any registrations with
PropertiesAutowired
applied would duplicate property injection with required properties.I decided to just blanket ignore required properties in the
DefaultPropertySelector
. My logic for this was as follows:If someone inside a lambda uses
Activator.CreateInstance
directly (for some reason) to bypass the required properties, those required properties won't be injected; but then, why aren't you using the reflection activator?