Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'credentials' field on 'RequestInitializerDict' is not implemented. #1100

Closed
randomairborne opened this issue Jul 20, 2023 · 7 comments
Closed
Labels
invalid This doesn't seem right question Further information is requested

Comments

@randomairborne
Copy link

randomairborne commented Jul 20, 2023

Hi! I'm trying to use this library on Cloudflare Workers, which does not implement fetch credentials. Is there a way to disable these? I've tried setting fetchRequestCredentials: null on OidcClientSettings, but it still throws the error.
issue-ref: cloudflare/workers-sdk#2514

@randomairborne
Copy link
Author

I have realized this is more of a bug in workers- I was wondering if this is something you actually wanted to fix, or if you'd rather wait for CF.

@pamapa
Copy link
Member

pamapa commented Aug 15, 2023

i wont do anything yet :-)

@pamapa pamapa added the question Further information is requested label Aug 15, 2023
@randomairborne
Copy link
Author

cloudflare/workerd#902 is the issue on the cloudflare repo. Thanks for your response.

@pamapa pamapa closed this as completed Aug 21, 2023
@randomairborne
Copy link
Author

is this actually fixed, or is it wontfix?

@pamapa
Copy link
Member

pamapa commented Aug 21, 2023

this can not be fixed in this library as you said its an issue here cloudflare/workerd#902, thus no need to track it here

@randomairborne
Copy link
Author

alright- do you mind using the "not planned" close feature instead? It's a little clearer.

@pamapa
Copy link
Member

pamapa commented Aug 22, 2023

I rather set the invalid label, as the bug you describe is not in this repo. E.g. RequestInitializerDict does not exist here.

@pamapa pamapa added the invalid This doesn't seem right label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants