Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version limit #41

Closed
micheleivani opened this issue Nov 26, 2021 · 5 comments · Fixed by #43
Closed

Node version limit #41

micheleivani opened this issue Nov 26, 2021 · 5 comments · Fixed by #43

Comments

@micheleivani
Copy link

Hello,

I tried to install the package on my node/express project but I got an error because my version node version (16.x.x or 17.x.x) is not supported. Right now node 16 version isLTS but I think you could have just a minimum version of node support, and not a range.

Thank you.

@adamjmcgrath
Copy link
Contributor

Thanks for raising this @micheleivani - investigating

@isaachinman
Copy link

@adamjmcgrath Thanks for merging a fix. Can you release this as soon as possible?

@adamjmcgrath
Copy link
Contributor

Hi @isaachinman @micheleivani - this was released in 1.1.0

@jvenema
Copy link

jvenema commented May 23, 2022

I'm getting a warning on this still - expected?

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'express-oauth2-jwt-bearer@1.1.0',
npm WARN EBADENGINE required: { node: '12.19.0 || ^14.15.0 || ^16.13.0' },
npm WARN EBADENGINE current: { node: 'v16.3.0', npm: '7.15.1' }
npm WARN EBADENGINE }

@adamjmcgrath
Copy link
Contributor

Hi @jvenema - yep this is expected

This SDK depends on jose which requires Node ^16.13.0 see panva/jose#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants