Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename 'decode' to 'unsafeDecode' #741

Closed
wants to merge 1 commit into from
Closed

rename 'decode' to 'unsafeDecode' #741

wants to merge 1 commit into from

Commits on Sep 2, 2020

  1. rename 'decode' to 'unsafeDecode' 

    'decode' is often reached to by well-meaning developers who assume that the call is safe. Unfortunately, this leads to untrusted JWTs being accepted as otherwise acceptable input.

Renaming 'decode' to 'unsafeDecode' signals to the end user that the method they are calling is indeed unsafe without them having to remember the difference between 'decode' and 'verify'.
    Dan Pantry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    d85caec View commit details
    Browse the repository at this point in the history