Remove javascript:void(0) from links that do not navigate (#1938)

* Remove javascript:void(0) from links that do not navigate

* Fix snapshots

Author: Steve Hobbs

src/__tests__/connection/passwordless/__snapshots__/email_sent_confirmation.test.jsx.snap

@@ -4,6 +4,20 @@ exports[`EmailSentConfirmation renders correctly 1`] = `
 <div
   className="auth0-lock-confirmation"
 >
+  <span
+    aria-label="close"
+    className="auth0-lock-close-button"
+    dangerouslySetInnerHTML={
+      Object {
+        "__html": "<svg aria-hidden=\\"true\\" focusable=\\"false\\" enable-background=\\"new 0 0 128 128\\" version=\\"1.1\\" viewBox=\\"0 0 128 128\\" xml:space=\\"preserve\\" xmlns=\\"http://www.w3.org/2000/svg\\" xmlns:xlink=\\"http://www.w3.org/1999/xlink\\"><g><polygon fill=\\"#373737\\" points=\\"123.5429688,11.59375 116.4765625,4.5185547 64.0019531,56.9306641 11.5595703,4.4882813     4.4882813,11.5595703 56.9272461,63.9970703 4.4570313,116.4052734 11.5244141,123.4814453 63.9985352,71.0683594     116.4423828,123.5117188 123.5126953,116.4414063 71.0732422,64.0019531   \\"></polygon></g></svg>",
+      }
+    }
+    id="__lock-id__-close-button"
+    onClick={[Function]}
+    onKeyPress={[Function]}
+    role="button"
+    tabIndex={0}
+  />
   <span
     aria-label="back"
     className="auth0-lock-back-button"
@@ -40,7 +54,7 @@ exports[`EmailSentConfirmation renders correctly 1`] = `
     <span>
       <a
         className="auth0-lock-resend-link"
-        href="javascript:void(0)"
+        href="#"
         onClick={[Function]}
       >
         

src/__tests__/field/__snapshots__/vcode_pane.test.jsx.snap

@@ -33,7 +33,7 @@ exports[`VcodePane disable input when submitting 1`] = `
   >
     <a
       className="auth0-lock-alternative-link"
-      href="javascript:void(0)"
+      href="#"
       onClick={[Function]}
     >
       resendLabel
@@ -59,7 +59,7 @@ exports[`VcodePane renders correctly 1`] = `
   >
     <a
       className="auth0-lock-alternative-link"
-      href="javascript:void(0)"
+      href="#"
       onClick={[Function]}
     >
       resendLabel
@@ -85,7 +85,7 @@ exports[`VcodePane sets autoFocus as true when \`isSmallScreen\` is false 1`] =
   >
     <a
       className="auth0-lock-alternative-link"
-      href="javascript:void(0)"
+      href="#"
       onClick={[Function]}
     >
       resendLabel
@@ -111,7 +111,7 @@ exports[`VcodePane sets isValid as true when \`isFieldVisiblyInvalid\` is false
   >
     <a
       className="auth0-lock-alternative-link"
-      href="javascript:void(0)"
+      href="#"
       onClick={[Function]}
     >
       resendLabel
@@ -142,7 +142,7 @@ exports[`VcodePane shows header when instructions are available 1`] = `
   >
     <a
       className="auth0-lock-alternative-link"
-      href="javascript:void(0)"
+      href="#"
       onClick={[Function]}
     >
       resendLabel

src/connection/database/login_pane.jsx

@@ -9,10 +9,10 @@ import * as l from '../../core/index';
 import CaptchaPane from '../../field/captcha/captcha_pane';
 
 export default class LoginPane extends React.Component {
-  handleDontRememberPasswordClick(e) {
+  handleDontRememberPasswordClick = e => {
     e.preventDefault();
     showResetPasswordActivity(l.id(this.props.lock));
-  }
+  };
 
   render() {
     const {
@@ -65,8 +65,8 @@ export default class LoginPane extends React.Component {
         <p className="auth0-lock-alternative">
           <a
             className="auth0-lock-alternative-link"
-            href={forgotPasswordLink(lock, 'javascript:void(0)')}
-            onClick={forgotPasswordLink(lock) ? undefined : ::this.handleDontRememberPasswordClick}
+            href={forgotPasswordLink(lock, '#')}
+            onClick={forgotPasswordLink(lock) ? undefined : this.handleDontRememberPasswordClick}
           >
             {forgotPasswordAction}
           </a>

src/connection/database/login_sign_up_tabs.jsx

@@ -54,14 +54,14 @@ LoginSignUpTabs.propTypes = {
 };
 
 class LoginSignUpTab extends React.Component {
-  handleClick(e) {
+  handleClick = e => {
     if (this.props.href) {
       this.props.clickWithHrefHandler();
     } else {
       e.preventDefault();
       this.props.clickHandler();
     }
-  }
+  };
 
   render() {
     const { current, href, label } = this.props;
@@ -72,7 +72,7 @@ class LoginSignUpTab extends React.Component {
         {current ? (
           <span>{label}</span>
         ) : (
-          <a href={href || 'javascript:void(0)'} onClick={::this.handleClick}>
+          <a href={href || '#'} onClick={this.handleClick}>
             {label}
           </a>
         )}

src/connection/passwordless/email_sent_confirmation.jsx

@@ -16,7 +16,7 @@ class ResendLink extends React.Component {
   render() {
     const { label, onClick } = this.props;
     return (
-      <a className="auth0-lock-resend-link" href="javascript:void(0)" onClick={onClick}>
+      <a className="auth0-lock-resend-link" href="#" onClick={onClick}>
         {label} <span dangerouslySetInnerHTML={{ __html: retrySvg }} />
       </a>
     );
@@ -29,7 +29,7 @@ class Resend extends React.Component {
 
     const resendLink = m.resendAvailable(lock) && (
       <ResendLink
-        onClick={::this.handleClick}
+        onClick={this.handleClick}
         label={m.resendFailed(lock) ? labels.retry : labels.resend}
       />
     );
@@ -56,16 +56,16 @@ class Resend extends React.Component {
     );
   }
 
-  handleClick(e) {
+  handleClick = e => {
     e.preventDefault();
     resendEmail(l.id(this.props.lock));
-  }
+  };
 }
 
 export default class EmailSentConfirmation extends React.Component {
   render() {
     const { lock } = this.props;
-    const closeHandler = l.ui.closable(lock) ? ::this.handleClose : undefined;
+    const closeHandler = l.ui.closable(lock) ? this.handleClose : undefined;
     const labels = {
       failed: i18n.str(lock, 'failedLabel'),
       resend: i18n.str(lock, 'resendLabel'),
@@ -75,7 +75,11 @@ export default class EmailSentConfirmation extends React.Component {
     };
 
     return (
-      <SuccessPane lock={lock} backHandler={::this.handleBack} closeHandler={closeHandler}>
+      <SuccessPane
+        lock={lock}
+        backHandler={() => this.handleBack()}
+        closeHandler={() => closeHandler()}
+      >
         <p>{i18n.html(lock, ['success', 'magicLink'], c.email(lock))}</p>
         <Resend labels={labels} lock={lock} />
       </SuccessPane>

src/field/vcode/vcode_pane.jsx

@@ -8,16 +8,16 @@ import { swap, updateEntity } from '../../store/index';
 import { setVcode } from '../vcode';
 
 export default class VcodePane extends React.Component {
-  handleVcodeChange(e) {
+  handleVcodeChange = e => {
     e.preventDefault();
     swap(updateEntity, 'lock', l.id(this.props.lock), setVcode, e.target.value);
-  }
+  };
 
-  handleResendClick(e) {
+  handleResendClick = e => {
     e.preventDefault();
     const { lock, onRestart } = this.props;
     onRestart(l.id(lock));
-  }
+  };
 
   render() {
     const { instructions, lock, placeholder, resendLabel } = this.props;
@@ -31,17 +31,13 @@ export default class VcodePane extends React.Component {
           lockId={l.id(lock)}
           value={c.vcode(lock)}
           isValid={!c.isFieldVisiblyInvalid(lock, 'vcode') && !l.globalError(lock)}
-          onChange={::this.handleVcodeChange}
+          onChange={this.handleVcodeChange}
           autoFocus={!isSmallScreen()}
           placeholder={placeholder}
           disabled={l.submitting(lock)}
         />
         <p className="auth0-lock-alternative">
-          <a
-            className="auth0-lock-alternative-link"
-            href="javascript:void(0)"
-            onClick={::this.handleResendClick}
-          >
+          <a className="auth0-lock-alternative-link" href="#" onClick={this.handleResendClick}>
             {resendLabel}
           </a>
         </p>

src/ui/pane/quick_auth_pane.jsx

@@ -19,7 +19,7 @@ const QuickAuthPane = props => {
     <p className="auth0-lock-alternative">
       <a
         className="auth0-lock-alternative-link"
-        href="javascript:void(0)"
+        href="#"
         onClick={e => {
           e.preventDefault();
           alternativeClickHandler(e);