Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0-react bundled with old version of @auth0/spa-js #198

Closed
weyert opened this issue Feb 15, 2021 · 5 comments
Closed

Auth0-react bundled with old version of @auth0/spa-js #198

weyert opened this issue Feb 15, 2021 · 5 comments
Labels
question Further information is requested

Comments

@weyert
Copy link

weyert commented Feb 15, 2021

Describe the problem

Appear that @auth0/spa-js gets bundled with 1.13.1 instead of 1.13.6

I would suggest to release a new version with the more recent version of @auth0/spa-js so we can benefit from the improvements.

@adamjmcgrath
Copy link
Contributor

Hi @weyert - if you install the latest version of auth0-react @auth0/auth0-react@1.2.0 you'll get the latest @auth0/auth0-spa-js release that satisifies the semver ^1.13.1 (as specified in the package.json), which is currently 1.13.6

⚡ mkdir my-app
⚡ cd my-app
⚡ npm init -f
⚡ npm install @auth0/auth0-react
⚡ npm list @auth0/auth0-spa-js
my-app@0.1.0
└─┬ @auth0/auth0-react@1.2.0
  └── @auth0/auth0-spa-js@1.13.6

@adamjmcgrath adamjmcgrath added the question Further information is requested label Feb 15, 2021
@weyert
Copy link
Author

weyert commented Feb 15, 2021

Yeah, but if you then do cat node_modules/@auth0/auth0-react/dist/auth0-react.cjs.js | grep 1.13.1 in that same directory its referring to 1.13.1 like:

return e.prototype._url=function(e){var t=encodeURIComponent(btoa(JSON.stringify(this.options.auth0Client||{name:"auth0-spa-js",version:"1.13.1"})));re

Did I misunderstand the code block?

@adamjmcgrath
Copy link
Contributor

D'oh - you're right @weyert, I forgot we did that - I'm doing a release shortly for #190 so I'll make sure I update the embedded version of SPA js

@weyert
Copy link
Author

weyert commented Feb 16, 2021

Thank you :)

@adamjmcgrath
Copy link
Contributor

no problem! released in https://github.com/auth0/auth0-react/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants