Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic in fetchBrandingSettingsOrUseDefaults #731

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

As pointed out in #515 (comment), the ul templates update command panics in case there are no branding settings returned by the API and no error.

This PR prevents that from occuring.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Apr 12, 2023
@sergiught sergiught marked this pull request as ready for review April 12, 2023 14:06
@sergiught sergiught requested a review from a team as a code owner April 12, 2023 14:06
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac090d1) 70.59% compared to head (a1af28c) 70.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files          87       87           
  Lines       11183    11183           
=======================================
  Hits         7895     7895           
  Misses       2775     2775           
  Partials      513      513           
Impacted Files Coverage Δ
internal/cli/universal_login_templates.go 46.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught merged commit a8146e1 into main Apr 12, 2023
@sergiught sergiught deleted the patch/fix-ul-templates-update-panic branch April 12, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants