DXCDT-327: test command --no-input compliance
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As reported by #511, the
auth0 test tokenandauth0 test logincommands do not respect the--no-inputflag because they open the browser and force an interaction. Instead, we should only provide the login URL and enable the user to facilitate the remainder of the login flow as they like. This approach is consistent to what we have implemented forauth0 login --no-input.📚 References
Original Github issue: #511
🔬 Testing
Currently, no integration tests are possible because of the commands waiting for browser callbacks and never exiting. All tests performed manually.
📝 Checklist