[4/4] DXCDT-317: Add confirmation prompt on open editor updates #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jan 11, 2023
| @@ -211,11 +212,20 @@ func updateEmailTemplateCmd(cli *cli) *cobra.Command { | |||
| &inputs.Body, | |||
| oldTemplate.GetBody(), | |||
| inputs.Template+".*.liquid", | |||
| cli.emailTemplateEditorHint, | |||
There was a problem hiding this comment.
Let's remove emailTemplateEditorHint as well.
There was a problem hiding this comment.
This is the only one I can remove safely:)
There was a problem hiding this comment.
Removed in ec270f6 (#603).
Widcket
reviewed
Jan 11, 2023
| @@ -310,11 +310,20 @@ func updateActionCmd(cli *cli) *cobra.Command { | |||
| &inputs.Code, | |||
| oldAction.GetCode(), | |||
| inputs.Name+".*.js", | |||
| cli.actionEditorHint, | |||
There was a problem hiding this comment.
Let's remove actionEditorHint as well.
There was a problem hiding this comment.
This is still being used in the create cmd.
Widcket
reviewed
Jan 11, 2023
| @@ -351,12 +351,21 @@ func updateRuleCmd(cli *cli) *cobra.Command { | |||
| &inputs.Script, | |||
| oldRule.GetScript(), | |||
| oldRule.GetName()+".*.js", | |||
| cli.ruleEditorHint, | |||
There was a problem hiding this comment.
Let's remove ruleEditorHint as well.
There was a problem hiding this comment.
This is still being used in the create cmd.
Base automatically changed from
patch/DXCDT-317-refactor-rules-update-part-3
to
v1
January 12, 2023 18:53
sergiught
force-pushed
the
patch/DXCDT-317-confirm-part-4
branch
from
ec270f6
to
2001b96
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The CLI asks for confirmation before an entity is deleted. However, we should also ask for confirmation before updating a template. The reason is because sometimes developers have a tough time wielding the built-in editor (ex: VIM) and accidents may occur; a confirmation would prevent any unintended updates. This practice is already employed with the universal login template. This can be overridden with a --force flag or if the templates are piped-in.
📚 References
🔬 Testing
📝 Checklist