DXCDT-304: Disable JSON flag for logs tail command #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
approved these changes
Jan 10, 2023
Widcket
approved these changes
Jan 10, 2023
sergiught
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As noted by #419 , the
--json(previously:--format) flag does not make sense in the context of log tailing. Alternatively, JSON encoding of logs should be retrieve fromauth0 logs list --json. This flag can always be re-added if the desired functionality is better understood, but until now, the defunct flag should be remove.📚 References
Original issue: #419
🔬 Testing
Removing functionality. No tests necessary.
📝 Checklist