DXCDT-321: Fix --no color flag
#594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
approved these changes
Jan 10, 2023
Widcket
approved these changes
Jan 10, 2023
sergiught
approved these changes
Jan 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Currently, the
--no-colorflag does not function for most operations. The reason for this failure is because the initialization of Aurora, the third-party color module, is done after the--no-colorflag is parsed. The quick remedy here is to re-initialize the Aurora instance once the value of the--no-colorflag is known. Ideally, we would reconstruct the code to only initialize the Aurora instance once, but during my trials, I found this to be quite cumbersome, leading to many nil reference errors. This at least fixes the functionality.Before:
After:
📝 Checklist