[1/2] DXCDT-291: Remove branding templates storybook preview #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sergiught
changed the title
Widcket
reviewed
Jan 10, 2023
Widcket
approved these changes
Jan 10, 2023
willvedd
changed the title
willvedd
changed the title
willvedd
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Currently, the Auth0 CLI uses Storybook to dynamically render previews of Universal Login Templates for developers. However, this comes at a maintenance cost and complexity overhead that resulted in a not so great developer experience as the templates need to constantly get updated:
auth0 branding templates updatefails to open external editor and cancels #412auth0 branding templates update#413So we're removing the local preview feature entirely and keeping just the update functionality. The reworked functionality is part of #593. We'll follow up with new commands that will open the preview within the dashboard itself instead.
📚 References
🔬 Testing
📝 Checklist