DXCDT-304: Adding headers to output of auth0 logs list
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
force-pushed
the
DXCDT-304-fix-no-logs-output-headers
branch
from
d0801f2
to
59ae843
Compare
Widcket
approved these changes
Jan 10, 2023
sergiught
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As reported by #474, the
auth0 logs listcommand was missing output headers. This PR implements a fix. They were missing because theauth0 logs listcommand shares the same rendering logic asauth0 logs tailand tail'ing the logs does not display the headers. The fix is to separate the rendering calls appropriately for each.📚 References
Original issue: #474
🔬 Testing
Added an integration test to assert the existence of these headers.
📝 Checklist