Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-307: Fix users search command to correctly search through result pages #588

Merged
merged 4 commits into from
Jan 10, 2023
Merged

DXCDT-307: Fix users search command to correctly search through result pages #588

merged 4 commits into from
Jan 10, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 9, 2023 •
edited
Loading

🔧 Changes

As mentioned in #485, the users search command only gives back the first 50 results and it doesn't keep looping through the paginated results.

In this PR we are adding a --number flag to be consistent with the other list commands and define a total amount of items to return.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the patch/DXCDT-307-users-pagination branch from 6accc43 to 217e5dc Compare January 9, 2023 11:07
@sergiught sergiught marked this pull request as ready for review January 9, 2023 11:12
@sergiught sergiught requested a review from a team as a code owner January 9, 2023 11:12
Base automatically changed from patch/follow-up-on-docs to v1 January 9, 2023 15:42
@sergiught sergiught force-pushed the patch/DXCDT-307-users-pagination branch from 217e5dc to d6ec4db Compare January 9, 2023 16:00
@sergiught sergiught force-pushed the patch/DXCDT-307-users-pagination branch from d6ec4db to e8d3a52 Compare January 9, 2023 16:05
willvedd
willvedd approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@sergiught sergiught merged commit ec19b23 into v1 Jan 10, 2023
@sergiught sergiught deleted the patch/DXCDT-307-users-pagination branch January 10, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiught @willvedd @Widcket