DXCDT-301: Storing client secret in keyring (2/2) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
willvedd
force-pushed
the
DXCDT-301-store-client-secret-in-keyring
branch
from
b0c1a84
to
db24bef
Compare
sergiught
force-pushed
the
DXCDT-301-store-client-secret-in-keyring
branch
from
e50f72f
to
4c4f2f8
Compare
sergiught
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Building off of #577 , this PR introduces the storage of a client secret in the OS keyring. Previously, this client secret was being written in to a plaintext config file, but this is not ideal for obvious security reasons.
During this PR it was discovered that there are size limitations when using
go-keyringbut the client secret is small enough to comply with all the platform restrictions.📚 References
Parent PR: #577
🔬 Testing
Adding unit tests for new functionality.
📝 Checklist