Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in auth0 ul customize to gracefully ignore specific prompt errors #1081

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

developerkunal
Copy link
Contributor

🔧 Changes

This PR improves error handling for the auth0 ul customize functionality, ensuring that specific prompt-related errors (such as "Your account does not have custom prompts" or "feature is not available for your plan") are gracefully ignored. This change prevents the function from failing due to these non-critical issues and enhances the robustness of the system.

  • Improved error checking for specific API responses related to unavailable features.
  • Updated relevant test cases to ensure proper handling of ignored errors.

📚 References

N/A

🔬 Testing

This change was tested with updated unit tests that verify:

  • Error handling for unavailable prompts or features, ensuring these errors are safely ignored.
  • Manual End-to-end testing with various branding settings and prompt customizations to validate system behaviour in different scenarios.

📝 Checklist

  • All new/changed functionality is covered by tests
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner October 1, 2024 07:33
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.05%. Comparing base (5ce0e13) to head (ec9e6a5).

Files with missing lines Patch % Lines
internal/cli/universal_login_customize.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1081   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          94       94           
  Lines       12938    12942    +4     
=======================================
+ Hits         9322     9326    +4     
  Misses       3069     3069           
  Partials      547      547           
Flag Coverage Δ
72.05% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal merged commit 2ab115f into main Oct 1, 2024
11 checks passed
@developerkunal developerkunal deleted the fix-custom-prompts-errors branch October 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants