Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency (Quick) #107

Closed
gitMartynas opened this issue Jun 2, 2021 · 4 comments · Fixed by #108, auth0/JWTDecode.swift#125, auth0/Auth0.swift#476 or auth0/Lock.swift#671
Closed

Comments

@gitMartynas
Copy link

Trying to add latest versions of Quick & Nimble frameworks into my project via SPM. But getting following error:

Dependencies could not be resolved because root depends on 'Quick' 4.0.0..<5.0.0 and root depends on 'SimpleKeychain' 0.12.2..<1.0.0.
'SimpleKeychain' >= 0.12.2 practically depends on 'Quick' 3.0.0..<4.0.0 because 'SimpleKeychain' 0.12.2 depends on 'Quick' 3.0.0..<4.0.0 and no versions of 'SimpleKeychain' match the requirement 0.12.3..<1.0.0.

Could you please update SimpleKeychain to use latest Quick & Nimble versions?

Also I was wondering if it is worth having these dependencies (Quick & Nimble) in such a small framework like SimpleKeychain. It contains only 20± unit tests. Please consider rewriting them using XCTest. Framework will become lighter and you will lose additional 3rd party dependencies.

@Widcket
Copy link
Contributor

Widcket commented Jun 2, 2021

Hi @gitMartynas, thanks for raising this. I just tried adding a name to the test dependencies so they don't get resolved, and that seems to solve the conflict.

Screen Shot 2021-06-02 at 19 39 18

Can you please try the test/spm-deps branch to see if that solves your problem? If so, I'll make a PR and then a new release.

@gitMartynas
Copy link
Author

gitMartynas commented Jun 3, 2021

Thanks @Widcket, looks like issue is resolved now, but another appeared. Should I create issue on Auth0 git repo? :)

Dependencies could not be resolved because root depends on 'Quick' 4.0.0..<5.0.0.
'Quick' 3.0.0..<4.0.0 is required because 'Auth0.swift' depends on 'Quick' 3.0.0..<4.0.0 and root depends on 'Auth0.swift' 1.30.1..<2.0.0.

@Widcket
Copy link
Contributor

Widcket commented Jun 3, 2021

No need to, I'll create the respective PRs and releases. Note that JWTDecode.swift needs to get the change first, as it's a dependency of Auth0.swift.

@Widcket
Copy link
Contributor

Widcket commented Jun 8, 2021

@gitMartynas this should be solved with Auth0.swift 1.33.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment