-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to customize SDK networking client #656
Comments
Hi @NicholasGWK this can be currently achieved this way
Does this help answer your query? |
Hey @poovamraj thank you for your response. We did try that, as Nick mentioned in his query, when making requests at runtime, the NetworkingClient used is the default one instead of this newly customized one that we implemented using the same method you posted above. So the customized one is not being used. Secondly, the proxy requires authorization so we wish to pass through a username and password with our requests to ensure requests go through. Any thoughts on this would be helpful. Thank you! |
@sabeehzaidi can you share how this request is made. If the same instance of The proxy implementation can be done based on how and which network stack you implement inside |
Hey @poovamraj it is the same interface implementation you mentioned above, but what I notice is that the calls end up in the
And this is the load() function of the
|
@sabeehzaidi can you show how you call the login/authentication method. I can see that the object is instantiated right but not sure whether it is being used while calling the method. |
@poovamraj we then proceed to use the
This proceeds to call the |
@sabeehzaidi we are not able to reproduce this locally. Can you provide us a sample application which reproduces this issue? You can even use our sample application (app module) within the repo and create a fork |
Hey all 👋 any update on this? |
Hey @poovamraj not yet but we'll get to it as soon as we can. Still in the pipeline as it will block future work. |
Checklist
Description
Hello there! I commented on a PR a bit ago but figured I'd make an issue for better visibility in case the PR isn't monitored:
#610 (comment)
Essentially, allowing customization of the Auth0 SDK Networking client wasn't implemented when Lock was upgraded to use v2, with a note to come back to it. My team is currently trying to do some proxy configuration which would require customization of the network client so this would be a great thing to have fixed if it's still able to be considered a bugfix 😅
Thanks so much for looking!
Reproduction
Additional context
No response
Lock.Android version
Latest
Android version(s)
Doesn't matter
The text was updated successfully, but these errors were encountered: