Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary adjustments with Tone EQ #158

Closed
pedrorrodriguez opened this issue Jun 2, 2023 · 1 comment
Closed

Primary adjustments with Tone EQ #158

pedrorrodriguez opened this issue Jun 2, 2023 · 1 comment
Assignees
Labels
enhancement priority: medium Affects basic and core functionnalities of the software in a way that mildly degrades usability

Comments

@pedrorrodriguez
Copy link
Collaborator

pedrorrodriguez commented Jun 2, 2023

This previous issue still applies:

#134

In addition, currently the UI of the Tone EQ module is mostly geared towards secondary adjustments. If one tries to make primary ones, things get awkward. Here are a couple of thoughts:

  • An adjustable histogram is not useful for primary adjustment. Having a way to set white and black levels would be faster to set up and easier to understand than posterization, exposure and contrast compensation.
  • 9 nodes are more than what's needed for primary adjustment. 5 would be enough. The right- and leftmost nodes would control white and black levels respectively. The middle one, midtones. The remaining two, highlights and shadows.
  • Curve smoothness adjustment is perhaps also not needed. Primary adjustments are broad and smooth.
@pedrorrodriguez pedrorrodriguez added enhancement priority: medium Affects basic and core functionnalities of the software in a way that mildly degrades usability labels Jun 16, 2023
@pedrorrodriguez pedrorrodriguez modified the milestone: 1.0 Jun 16, 2023
@pedrorrodriguez
Copy link
Collaborator Author

For primary and secondary adjustments use two instances of tone EQ with different curve smoothing, so that the first is very broad, and the second very precise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority: medium Affects basic and core functionnalities of the software in a way that mildly degrades usability
Projects
None yet
Development

No branches or pull requests

2 participants