-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception thrown. Possible issue with multiple narrators in a book? #15
Comments
Thanks for the call stack. I'll check it. |
I may have an idea now. There is some inconsistency in the code. How many authors are there for these books? Did you change any author names in the preview window? |
Book 1: two authors separated by comma, one narrator. Names are "simple" (Name Surname). "Add Narrator" = Yes Throws no error when opening the Preview window. Throws error during conversion when tags are not modified in the Preview window. Editing the "File" / "Author" field by removing the comma makes no difference. Error is thrown. A few files are output before the exception, but they lack all tags. Editing the "Tag" / "Author" field by removing the comma works. Error is not thrown. The tags in the resulting files show the names of the "two" authors and one narrator separated by a semicolon ( ; ). Example: Name1 Name2; Narrator1 Book 2: three authors, two narrators. Authors separated by comma. Narrators separated by semicolon. Author names are "complex" (Name L. L. Surname, Name L. Surname Jr.). Narrators are "simple". (Names don't seem to be an issue by themselves, but just in case, I tell you this.) "Add Narrator" = Yes Throws no error when opening the Preview window. Throws error during conversion when tags are not modified in the Preview window. Editing the "File" / "Author" field by removing the comma makes no difference. Error is thrown. A few files are output before the exception, but they lack all tags. Editing the "Tag" / "Author" field by removing the comma works. Error is not thrown. The tags in the resulting files show the names of the "three" authors and two narrators separated by two semicolons. Example: Name1 Name2 Name3; Narrator1; Narrator2 |
Thank you. That confirms my assumptions. I think the point is how the authors are separated,. The tag structure used in aax/m4a files supports multiple authors and narrators, encoded as arrays. But if Audible puts multiple authors in the same single array item, separated by comma or semicolon, AAX Audio Converter will nonetheless treat them as multiple. However, when rewriting the tags to the output file, the counting may go wrong. And that eventually will lead to array items for the performers' role ("Author" or "Narrator") left with null. And then you get the null pointer exception. I will rewrite that short section of code to prevent this. |
Fixed in version 1.9. |
Version: 1.8
Net Framework: 4.8.3752
Windows 10 64bits
After upgrading from 1.6, I've been converting all my audiobooks without issues.
However, on trying to convert a particular audiobook, I get this problem:
This audiobook differs from others in that it has two narrators listed.
EDIT: Looks like the issue is the narrator tag, because in the "Naming" section of the program, if I set "Add Narrator" to "No", the exception is not thrown. The audiobook is converted without issues.
EDIT 2: Having further trouble with a second audiobook. But this one has one narrator. :P
Moving on... what they do have in common is that both have more than one authors. They throw the exact same exception. And if I set "Add Narrator" to "No", both audiobooks get converted correctly.
The text was updated successfully, but these errors were encountered: