-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nushell): update commandline
syntax, closes #1733
#1735
Conversation
The next nushell release is scheduled for 5th of March. |
Is it possible to check the Nushell version and support both versions? |
I could do that, but this adds the additional burden of removing the code later down the track. I feel like Nushell is still unstable, so people should update regularly anyway. |
Nushell does populate |
Nushell itself is apparently going to support the old way for 1 release before deprecating. Some of Atuin's users may be on platforms where they aren't running the absolute latest Nushell. This change as written will cause Atuin to deal with the Nushell breakage, as anyone on older versions of Nushell will not get an appropriate warning message and will think Atuin has the bug. That will be far more burden than removing the code down the line. Nushell having breaking changes is fine, but all programs trying to work with Nushell, like Atuin, will be trying to support older versions where possible. Having a point in time where a user has to update both Nushell and Atuin at exactly the same time is unreasonable. |
True. I suppose Atuin and Nushell won't always update at similar times. I've added backwards compatibility for Nushell <= v0.90. |
6af6043
to
f82189a
Compare
f82189a
to
561401b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
This should be merged when the next version of Nushell releases, where it'll change the
commandline
syntax.Checks